Allow the expressions like 'v.tag' in return #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtcyclist
force-pushed
the
fix_return_v_tag
branch
from
770e36e
to
0dc2592
Compare
xtcyclist
requested review from
czpmango,
nevermore3,
Aiee,
codesigner,
jievince,
Shylock-Hg and
yixinglu
and removed request for
czpmango
xtcyclist
added
do not review
xtcyclist
added
ready for review
and removed
do not review
yixinglu
reviewed
Mar 28, 2023
| break; | ||
| } | ||
| auto tagId = ret.value(); | ||
| propsUsed_.insertVertexProp(entityAlias, tagId, "*"); |
There was a problem hiding this comment.
Is it necessary to insert edge and vertex props at same time? maybe only need to handle one branch by checking where the prop is from?
There was a problem hiding this comment.
I just found e.likeness wouldn't reach here... Maybe this part was outdated. Let me check.
There was a problem hiding this comment.
It goes into Kind::kSubscript as $-.e[0]. Maybe we can delete it already. 算了，不敢删。
There was a problem hiding this comment.
Seems like we don't have sufficient information here to tell them apart. Any advise?
nevermore3
approved these changes
Mar 28, 2023
Aiee
approved these changes
Mar 28, 2023
yixinglu
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix #5329
Description:
'v.tag' means all properties of that tag are needed. They shall not be pruned by the optimizer.
How do you solve it?
Add a wildcard
"*"into the VertexProp map in the tracker when encountered expressions likev.tagafter thetaghas been verified to be a real tag.Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: